Update git submodules
486add21557eUnpublished
Actions

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.
Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update git submodules

Update extensions/GrowthExperiments from branch 'wmf/1.34.0-wmf.21' to rEGRE47e414186704
- Homepage: Unbreak question dialogs on mobile
  
  Now that every module is in the page HTML in a hidden div, our code to attach click handlers to the "ask a question" buttons is attaching them to the hidden buttons, not the visible ones in the overlays.
  
  Fix this by using the second $content parameter passed to the OverlayHtmlLoaded hook to scope the button selectors.
  
  Follow-up to 4aca04d7890013.
  
  Bug: T229271 Change-Id: Ib440c91025fd841345e5df2a4d15a7a62b192e74 (cherry picked from commit 735a3ade227605be875d3fdc572232ef3bf5fd2d)

Details

Provenance

Catrope	Authored on Sep 3 2019, 9:11 PM
Gerrit Code Review	Committed on Sep 4 2019, 5:46 PM

ChangeId

None

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.