HomePhabricator

installer: Detect APC for MainCacheType in CLI installer
7e0677c7e214Unpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

installer: Detect APC for MainCacheType in CLI installer

The web installer did this already, but with the CLI installer,
the generated LocalSettings.php always contained the following
hardcoded:

$wgMainCacheType = CACHE_NONE;

Combined with the fact that in WMF CI, the generated local settings
is applied *after* the inclusion of Quibble settings and
DevelopmentSettings, meant that it was not possible to enable
object caching.

For now, make it match the behaviour of the web installer and thus
output $wgMainCacheType = CACHE_ACCELL if we detect a supported
implementation in the PHP runtime.

For later we should probably:

  • Make this an option to install.php,
  • or, change Quibble to append its overrides, instead of prepending. So that DevelopmentSettings actually after the generated LocalSettings.

Bug: T225496
Change-Id: I3f43cd054ce71d0f1b2395302e8ef9ee2f6b01c2
(cherry picked from commit 7e0fb4fff6a247802c2209df48cf9fab8bfb8563)

Details

Provenance
KrinkleAuthored on Jun 13 2019, 2:06 PM
Jdforrester-WMFCommitted on Jun 17 2019, 11:25 PM
Parents
rMW5470db242ef8: Disable rate limiting in Development Settings
Branches
Unknown
Tags
Unknown
ChangeId
I3f43cd054ce71d0f1b2395302e8ef9ee2f6b01c2