rdbms: avoid dbSchema() in Database::replaceLostConnection() and Database…
903f3f94f5d2Unpublished
Actions

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.
Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

rdbms: avoid dbSchema() in Database::replaceLostConnection() and Database::__clone()

Since dbSchema() always casts the result to a string, using this method
with a call to open() is broken if the RDBMs does not support DB schemas
and thus requires null

Follows-up 7911da9c6f (last week), which added the check in
DatabaseMysqlBase::open() check. Also follows fe0af6cad (last year),
which made dbSchema() consistently return string. Before that, an
implicit null was passed in from Database::factory for mysql, which hid
the class default of empty string.

Bug: T227708
Change-Id: I67207fbaa39c5cc3fe062077cc654f048090e009

Details

Provenance

aaron	Authored on Jul 11 2019, 1:21 AM
Krinkle	Committed on Jul 11 2019, 1:53 AM

ChangeId

I67207fbaa39c5cc3fe062077cc654f048090e009

Event Timeline

Stashbot mentioned this in T227708: DatabaseMysqlBase: domain schemas are not supported..Jul 11 2019, 2:45 PM

Commit No Longer Exists

This commit no longer exists in the repository.