HomePhabricator

Fix signature of DatabasePostgres::buildGroupConcatField
998e0cf00972Unpublished

Unpublished Commit · Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Fix signature of DatabasePostgres::buildGroupConcatField

The method in the postgres layer has an extra argument in the middle,
making the last parameter unused and the join condition is not passed to
build the subquery.
For usage of that function with a join the join condition are missing
and making the subquery returning a cartesian product, in case of change
tags with all existing tags in the wiki.

The code is there since the addition of the function in a974025
It is first used in a in a5500e7 for the change tags

Bug: T195807
Bug: T256401
Change-Id: I4e73e37d176a6368e65aeb21e5dbed14edd24f19
(cherry picked from commit db9e0391d73f4d7846e2d1dcde5ef1321d0c0b25)

Details

Provenance
UmherirrenderAuthored on Jan 22 2022, 10:40 AM
AmmarpadCommitted on Jan 24 2022, 6:17 AM
Parents
rMWddc2c9598127: update.php: Avoid passing null to substr
Branches
Unknown
Tags
Unknown
ChangeId
I4e73e37d176a6368e65aeb21e5dbed14edd24f19

Event Timeline