HomePhabricator

Update git submodules
c33a0f6af7c1Unpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Update git submodules

  • Update extensions/ConfirmEdit from branch 'REL1_32' to 198612589290e1d4301e1121bea338d74a9df107
    • Do not ignore message parameters

      The return value of the getMessage function is intentionally a Message object (which can have different stuff, be a RawMessage or contain parameters. Just getting the key of the message, passing it to another function which just creates a new message out of it, doesn't make sense and breaks the original intention of the method.

      This is now fixed by this change.

      Bug: T222590 Change-Id: Id8ebba6b8239e6eee4be698680edcafad6c86cb0 (cherry picked from commit a46515f782d5e446fd908247ec754a27b87cb9af)

Details

Provenance
FlorianAuthored on May 18 2019, 7:27 PM
Gerrit Code ReviewCommitted on May 19 2019, 10:17 AM
Parents
rMWf11d274bbaf7: Remove useless use of current and end
Branches
Unknown
Tags
Unknown
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rMWc33a0f6af7c1: Update git submodules (authored by Florian).May 19 2019, 10:17 AM