HomePhabricator

Update git submodules
c5c79e5cd98fUnpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update git submodules

  • Update extensions/VisualEditor from branch 'wmf/1.35.0-wmf.5' to rEVEDb1a5f722d49e
    • ve.init.mw.ArticleTarget: Fix error handling in #prepareCacheKey

      If the paction=serializeforcache request fails, we were erroneously converting it to a successful result with no value, which later causes an exception, because since 381b58585cc4e6a74e64fb2669af2a7635b09100 other code expects the result to an an object.

      The bug was introduced in 2015 in 07001001be794efba90fa0e81b212280db4b7784, but until that recent change it would only cause a 'badcachekey' error, which was handled correctly later.

      Change-Id: Ie1ffc8c3e616a7d296f2186fb17eaf039971a44f (cherry picked from commit a53c02f2c4ed1d653f9f466e496b74a1d3ec3f59)

Details

Provenance
matmarexAuthored on Nov 7 2019, 12:36 AM
Gerrit Code ReviewCommitted on Nov 7 2019, 7:15 PM
ChangeId
None

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.