HomePhabricator

Update git submodules
d50b699badebUnpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update git submodules

  • Update extensions/Translate from branch 'wmf/1.34.0-wmf.1' to rETRA225e2f2f6196
    • Remove problematic Job::$params assignments

      The parent constructor already does this. Doing it again was previously redundant, and is now actually causing a breakage, as the parent is also adding some additional default parameters keys (for title handling) that are now being overwritten (given that arrays are ref-by-value in PHP).

      Bug: T221368 Change-Id: I13bf550ed0c8c6329a49f147ef7b3cf373a86e7b

Details

Provenance
KrinkleAuthored on Apr 18 2019, 7:32 PM
Gerrit Code ReviewCommitted on Apr 18 2019, 8:31 PM
ChangeId
None

Event Timeline

Gerrit Code Review <gerrit@wikimedia.org> committed rMWd50b699badeb: Update git submodules (authored by Krinkle).Apr 18 2019, 8:31 PM

Commit No Longer Exists

This commit no longer exists in the repository.