HomePhabricator

Update git submodules
d8c8c316b30fUnpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Update git submodules

  • Update extensions/MobileFrontend from branch 'wmf/1.31.0-wmf.17'
    • Fix regressions with updated lead intro transform

      This is a combination of 2 commits:
      1. Avoid notice in lead paragraph transform when encounter infobox like elements

        XPath query can return tables that look like infoboxes as contains(@class,"infobox") is not the same as hasClass('infobox'). Thus getInfoboxContainer can resolve to false. This test and fix guards against that.

        Bug: T185106 Change-Id: I5a8fbbb956365de9af09ee8d238fb3389e8f2cef
      2. Remove blacklisted content before applying transforms

        Previously we removed all blacklisted elements AFTER applying transforms such as moving lead paragraph.

        This is unnecessary and can lead to problems, for example infoboxes inside elements which are to be removed, might be moved above the lead paragraph and skip the blacklisting altogether. This also leads to unnecessary logging when the move is not possible.

        HtmlFormatter::filterContent takes care of content removal so lets do that BEFORE our transformations explicitly.

        Bug: T185040 Change-Id: I18bc97fa37bdc53e61cb6de79fb6bc1158ffd9fe

Details

Provenance
Konfused-KittenAuthored on Jan 17 2018, 7:37 PM
Gerrit Code ReviewCommitted on Jan 18 2018, 12:23 AM
ChangeId
None

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.