SqlBlobStore HOT FIX: remove caching from getBlobBatch
f8ed2438bae0Unpublished
Actions

Unpublished Commit · Learn More

Publishing Disabled: All publishing is disabled for this repository.
Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

SqlBlobStore HOT FIX: remove caching from getBlobBatch

This is a TEMPORARY HACK to fix a problem with cached values
getting mixed up when using getBlobBatch(). As of the creation of this
patch, the actual cause is unknown. Caching should be put back once the
cause of the problem has been found.

Note that getBlobBatch is only used in maintenance scripts.
Removal of caching in that method has no effect on web requests.

getBlobBatch() was introduced in I56306c50a661 and is used by
RevisionStore::getContentBlobsForBatch(), which in turn is needed
by the Translate extension to remove its dependency on the deprecated
rev_text_id field.

Bug: T235188
Change-Id: I94c6f9ba7b9caeebaa9b055916f15f7bbdcd8fb6

Details

Provenance

daniel	Authored on Oct 11 2019, 9:21 AM
MaxSem	Committed on Oct 14 2019, 8:26 PM

ChangeId

I94c6f9ba7b9caeebaa9b055916f15f7bbdcd8fb6

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.