HomePhabricator
Diffusion extension-MobileFrontend fd45af39ff97

Making sure that clicking on search doesn't trigger history.back()
fd45af39ff97
Actions

Tags
None
Referenced Files
None
Subscribers
None
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Making sure that clicking on search doesn't trigger history.back()

As part of this, I'm removing the weird setTimeout on the router
navigation for search. I've tested this in Mobile Safari, Chrome 35
on Android, and the native Android browser (4.1.1), and didn't have
any problems with the keyboard. Perhaps it was a bug in an old
version of Chrome.

Also adding some more comments to SearchOverlay.js.

Bug: 67140
Change-Id: If6149cb5b8236c6d701a8441ac85360ba06240b0

Details

Provenance
kaldariAuthored on
ChangeId
If6149cb5b8236c6d701a8441ac85360ba06240b0

Commit No Longer Exists

This commit no longer exists in the repository.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL